To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=97538 Issue #|97538 Summary|psprint: ambiguous && || Component|gsl Version|DEV300m37 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|pl Reported by|cmc
------- Additional comments from c...@openoffice.org Tue Dec 23 17:02:26 +0000 2008 ------- In psprint/source/fontsubset/gsub.cxx (this code also appears in vcl as well) there is some unbracketed && || which looks dodgy i.e. if( (aFeatureIndexList[0] != nFeatureIndex) && (!std::count( aReqFeatureTagList.begin(), aReqFeatureTagList.end(), nTag)) || (!std::count( aFeatureIndexList.begin(), aFeatureIndexList.end(), nFeatureIndex) ) ) patch 1 make the implicit logic explicit, i.e. keeps things as they are, while patch 2 changes the logic to be what *might* have been meant. I can't really tell which is the correct one :-) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
