To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=97608 Issue #|97608 Summary|Remove Guiddef.h inclusion from fpicker/source/win32/f |ilepicker/VistaFilePickerImpl.cxx Component|porting Version|DEV300m37 Platform|PC URL| OS/Version|Windows, all Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|tono Reported by|tono
------- Additional comments from t...@openoffice.org Sun Dec 28 03:01:07 +0000 2008 ------- >From m38 cws hrovista3_DEV300 is integrated and fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx is modified to include win32 system header Guiddef.h. However, the header is included from other system headers and the inclusion is redundant. Moreover, MinGW does not have Guiddef.h and the inclusion breaks MinGW build. I have confirmed it can be safely removed even in build with MS VC 2008 Experess. A patch follows. @hro: I am planning to include the patch in next round of MinGW catchup fixes although it is not a pure porting fix. If you have another cws that is more appropriate, please let me know. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org For additional commands, e-mail: issues-h...@porting.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
