To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=95688
------- Additional comments from s...@openoffice.org Mon Jan 26 10:27:17 +0000
2009 -------
cws/macmiscfixes/shell/source/unix/misc/senddoc...@266859 does not look like a
good fix to me. First, instead of removing the leading space again one could
better not add it in the first place ("${ATTACH:+ }$2" instead of "${ATTACH:+ }
$2" in line 332). Second, "${ATTACH}" in call to /usr/bin/open will not work if
there are multiple --attach arguments to senddoc.sh. Third (and this is a
minor case, pertaining to all the cases in senddoc.sh), "while [ "$1" != "" ]"
fails to look past empty arguments. The second problem cannot be solved in
plain sh (at least I have no idea how to do it), but since this case (calling
/usr/bin/open) appears to be Mac OS X specific, and /bin/sh supports Bash
extensions on Mac OS X, something like the following---using Bash
arrays---should be a working replacement (in addition to addressing problems two
and three mentioned above, thanks to "${1?}" it will also cause senddoc.sh to
fail if an --attach misses its argument):
my_n=$#
unset my_attach
for ((my_i=0; my_i<my_n; ++my_i)); do
if [ "$1" == --attach ]; then
shift
((++my_i))
my_attach[${#my_atta...@]}]=${1?}
fi
shift
done
/usr/bin/open -a "${MAILER}" "${my_atta...@]}"
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
