To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99711 Issue #|99711 Summary|stoc: unused code and bogus code Component|udk Version|DEV300m42 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|kr Reported by|cmc
------- Additional comments from c...@openoffice.org Fri Feb 27 10:44:44 +0000 2009 ------- in stoc/source/servicemanager/invocation.cxx we have some weirdness. a) pItems = new MemberItem[nTotalCount] with no matching delete[] b) ppItems = new MemberItems*[nTotalCount] with no matching delete[] c) the address of each item in pItems is assigned to a position in ppItems and then we sort "ppItems", so we have a nicely ordered set of pointers in ppItems. And then we traverse "pItems" in order, which of course remains in the original order. The intent may have been to either sort "pItems" or to traverse "ppItems" in order. Attached is option1 and option2. option1 removes ppItems and adds delete[] pItems and removes the useless sort, so current behaviour continues. Probably the preferred option, as what we're doing now presumably has been what we've been doing for a decade or so, so why change it. option2 removes ppItems and adds delete[] pItems and changes the sort to sort pItems which might have been the original intent --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@udk.openoffice.org For additional commands, e-mail: issues-h...@udk.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
