To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100910
------- Additional comments from mme...@openoffice.org Tue Apr 7 11:32:37 +0000 2009 ------- > "Since SfxVoidItem is not inherited from" is nothing we can make sure. Sure you can - I just did an opengrok search, and empirically it is so. Whether it will remain so in the future is open to question, but after 10+ years of no inheriting, why are we likely to start now ? ;-) > It might be unlikely that someone inherits from an SfxVoidItem, but > since it could happen, what about: > > if ( (*ppFnd)->Type() == TYPE(SfxVoidItem) ) || > (*ppFnd)->IsA(TYPE(SfxVoidItem)) ) The common case is that the item is not a VoidItem I believe; so - the initial check would immediately fail, and then for every other type of item we would dive down the same chain of functions all checking that a 'SvxWeightItem' is not void, and that it's parent a 'SfxEnumItem' is not void, and it's parent a 'CntEnumItem' and so on ad infinitum & ad nauesum. So this would help not at all. > Or should "ISA(...)" make the == quick check in general first, assuming > most ISA calls match because of == ? Again - that is not going to help. The problem is that the type system is unaware that it is always comparing a leaf node in the type tree with something that is obviously not derived from it: of course, more cunning things are possible - but you'd want something like GObject's GType, and a more substantial type system, with a decent registry to do better here. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@util.openoffice.org For additional commands, e-mail: issues-h...@util.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
