To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=88878
------- Additional comments from f...@openoffice.org Thu May 14 08:10:25 +0000 2009 ------- Noel, this is great! The patch is *nearly* perfect :), only a couple of minor issues/questions: - VCLXWindow::getProperty( EnableVisible ): shouldn't this return isEnableVisible()? - both the sdtandard and the copy ctor of OGridControlModel miss an initialization of m_bEnableVisible. Same for ONavigationBarModel's copy ctor. - Not sure if in the file format, I would prefer calling the attribute "visible" instead of "enablevisible" (which for consistency reasons would need to be "enable-visible", btw.) I know you don't like EnableVisible at all :) I still think that API-wise, it does make sense, at the very least for the scenario where somebody uses the property together with the XWindow::setVisible method, here "EnableVisible" is way much clearer than "Visible" would be. But for the file format, there is no such argument. - I suppose it is intended that invisible controls are still printed? So conceptually, "EnableVisible" is a "show on screen", where "Print" is a "show on printer", and both are orthogonal. Makes sense, /me thinks. - persistency for the dialog case is missing, as you said yourself already. - The UI in the property browser is missing (I'll attach an updated version of the patch for this) - I didn't look at the SVX code, this is in Daniel's competency --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
