To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=84497


User rt changed the following:

                What    |Old value                 |New value
================================================================================
        Target milestone|---                       |DevTools
--------------------------------------------------------------------------------




------- Additional comments from r...@openoffice.org Fri May 15 07:55:12 +0000 
2009 -------
Concerning the 'main' patch: I do not know whether this $(QUIET_BUILD) thing has
any side effects, but for me it looks good. Anyone tested it yet? Ause, what do
you think?
Thanks, Thorsten, for the effort.

For the concept: We once proposed and started to introduce three levels of
verbosity:

default:
    no extra configure option
    environment variable VERBOSE unset

silent:
    configure option '--disable-verbose'
    environment variable VERBOSE="FALSE"

verbose:
    configure option '--enable-verbose'
    environment variable VERBOSE="TRUE"

This does not fit the to part of the patch concerning settings.mk
+.IF "$(VERBOSE)"=="" && "$(verbose)"==""
+QUIET_BUILD*=@
+.ELSE
+QUIET_BUILD*=
+.ENDIF
+

Thorsten, do I understand you correctly that your changes are meant for the
default case? If so, we should conditionalize as
.IF "$(VERBOSE)"=="TRUE"
QUIET_BUILD*=
.ELSE
QUIET_BUILD*=@
.ENDIF

If instead we only want it for the 'silent' case that of course should look the
other way round, set 'QUIET_BUILD*=@' if and only if  "$(VERBOSE)"=="FALSE"

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org
For additional commands, e-mail: issues-h...@tools.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to