To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=101952
                 Issue #|101952
                 Summary|sw: ambiguous && || has possibility to deference NULL
               Component|Word processor
                 Version|DEV300m48
                Platform|All
                     URL|
              OS/Version|Linux
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|code
             Assigned to|ama
             Reported by|cmc





------- Additional comments from c...@openoffice.org Fri May 15 09:50:01 +0000 
2009 -------
in source/core/crsr/pam.cxx we have...

if( pNd &&
     ( ... ) ||
     ( !bInReadOnly && pNd->FindSectionNode() &&
       pNd->FindSectionNode()->GetSection().IsProtect() ))
{
}

i.e. by precedence that's

if( (pNd && ( ... )) ||
     ( !bInReadOnly && pNd->FindSectionNode() &&
       pNd->FindSectionNode()->GetSection().IsProtect() ))
{
}

so if pNd == NULL then pNd can be dereferenced after the || which is
presumably not what's intended. More than likely the logic if the following
patch is intended

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to