To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91226
------- Additional comments from m...@openoffice.org Fri Jun 19 10:16:57 +0000 2009 ------- I made another code review and found some changes that I would like to discuss. Let's do it one after another. First: In SwCrsrShell::UpDown() code was added that reverted bUp eventually. IMHO this is not the right place for this, all writing direction dependent code should be where the cursor keys are handled, in the KeyInput method of the EditWindow. In the cursor shell "up" and "down" are only logical directions, means: for e.g. traditional mongolian layout it means "left" and "right" on the screen. Conversion from "phyical screen direction" to "logical direction" should be done before calling this method, otherwise e.g. the TextCursor UNO API calls that already use logical directions and forwards to SwCrshrShell:UpDown() wouldn't work correctly. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
