To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=103805
User cloph changed the following:
What |Old value |New value
================================================================================
CC|'' |'cloph'
--------------------------------------------------------------------------------
Assigned to|rene |ihi
--------------------------------------------------------------------------------
Keywords| |oooqa
--------------------------------------------------------------------------------
------- Additional comments from cl...@openoffice.org Sun Jul 26 23:39:18 +0000
2009 -------
I don't consider this fixed by just silencing it.
The whole section doesn't make much sense to me.
the $(eq,$(var),$(NULL) ...) is silly as well, since dmake has a dedicated check
for null.
But even that is not necessary, since there is the *= (i.e. only do the
assignment, if there is no value yet)
Really: If you add so magic, you're not even convinced yourself of (ref the TODO
-comment): At least add what is intended with that mess.
concrete: Why strip? Why the echo? Why the multiple assignments to LOCALIZESDF
with forced silencing of errors? I mean if you use !, you need to have good
reason (and should state it).
When adding such "monsters", you really ought to add a comment as to why those
quirks are used, and why the straightforward way cannot be used/is not suitable.
And wrt commented-out code: If you only comment it out, you can as well just
delete it. Version-control history can bring it back. If there is a reason to
keep it in the file itself: justify in a comment. But a reference to the concept
along with a pointer to the file's history would be far more useful IMHO
Reopen, assign to ihi to answer the above.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org
For additional commands, e-mail: issues-h...@tools.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
