To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=104829


User fs changed the following:

                What    |Old value                 |New value
================================================================================
             Assigned to|fs                        |ihi
--------------------------------------------------------------------------------
                 Summary|[CWS dba32g] cannot build |cannot build with non-empt
                        |with non-empty WITH_LANG o|y WITH_LANG on wntmsci12
                        |n wntmsci12               |
--------------------------------------------------------------------------------




------- Additional comments from f...@openoffice.org Mon Sep  7 21:55:07 +0000 
2009 -------
fs->ihi: In solinc/inc/target.mk, there's the following line:
  @@$(IFNOTEXIST) $(LOCALIZESDF) $(THEN) unzip -o -d
  $(COMMONMISC)$/$(PRJNAME)_$(TARGET) $(SOLARCOMMONSDFDIR)$/$(PRJNAME).zip 
(without the line break)

Which, resolves to
  if ! test -f ../../common/misc/vcl/source/src/localize.sdf ] ; then unzip -o
  -d ../../common/misc/vcl_svsrc g:/dev/o_dba32g/DEV300/common/sdf.m57/vcl.zip

Note that this is not a valid bash statement, there's a "; fi" missing at the
end. If I add an "$(FI)" to the very end of the rule in target.mk, then
everything works like a charm.

Why this doesn't happen on the MWS (or, more precise: not always ... meanwhile I
think I perhaps really saw it in an MWS env) is completely beyond me. According
to target.mk:1391-1393, it means that either LOCALIZESDF is empty, or
LOCALIZATION_FOUND is /not/ empty. The last sounds quite impossible, given that
LOCALIZATION_FOUND seemingly is *nowhere* set in solenv/inc/*, so I would assume
it is always empty.

Nonetheless, IMO the fix belongs to target.mk. IFNOTEXIST seems to be newly
introduced, and given that unitools.mk defines it to some "if ...", it indeed
should be accompanied by a $(FI), /me thinks.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org
For additional commands, e-mail: issues-h...@tools.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to