To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=103899
------- Additional comments from p...@openoffice.org Thu Sep 17 12:10:24 +0000 2009 ------- I think the vcl part of the changes could be improved a little - a PushButton that simply draws differently could easily be achieved by deriving from PushButton and overloading the virtual Paint method; the patch instead calls an extra virtual method in the base class. - I'm not sure what ExecuteModeless would achieve; the normal way to show a modeless window is calling Show(). If you need to be synchronous around that, you can do the while loop doing Application::Reschedule outside the dialog. Alternatively you can overload the Execute method in your derived Dialog so it does not behave like the normal Execute. - short DialogExBase::Execute() attempts to fiddle with the vptr of DialogExBase. That is not a good idea and might not be portable to all compilers - please remember that the vtable is an implementation detail of the compiler, there is no guarantee whatsoever where relative to the this ptr it is located. If you need to cast to different class, please do a dynamic_cast to that type. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
