To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106575
Issue #|106575
Summary|box-base.cxx: use of erased data
Component|tools
Version|DEV300m63
Platform|All
URL|
OS/Version|Linux
Status|UNCONFIRMED
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|code
Assigned to|mh
Reported by|dcb314
------- Additional comments from dcb...@openoffice.org Tue Nov 3 11:54:25
+0000 2009 -------
For source code file toolkit/source/layout/core/box-base.cxx,
function Box_Base::removeChildData, is the following code
for ( std::list< ChildData* >::iterator it = lst.begin();
it != lst.end(); it++ )
{
if ( (*it)->mxChild == xChild )
{
lst.erase( it );
return *it;
}
}
It seems to be most unwise to return data after it has been
erased.
Suggest untested code like
for ( std::list< ChildData* >::iterator it = lst.begin();
it != lst.end(); it++ )
{
if ( (*it)->mxChild == xChild )
{
ChildData * tmp = *it;
lst.erase( it );
return tmp;
}
}
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org
For additional commands, e-mail: issues-h...@tools.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
