To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106833


User pl changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from p...@openoffice.org Thu Dec  3 16:44:26 +0000 
2009 -------
Ok, what is wrong is the Encoding vector (and is plain wrong, the actual encoded
value for the glyph is already '1' as it should be). The Encoding vector however
seems to be not the first place most programs look for the glpyh, it seems to be
the CharStrings array.

The entries of the encoding vector are originally created in
vcl/unx/source/printergfx/glpyhset.cxx in GlyphSet::PSUploadFont. The encoded
entries come from a hash_map, which is not sorted; but that should not be
necessary anyway since the decription comes as a glyph array and an encoding
array. This then goes into FontSubsetInfo, which uses CreateT42FromTTFont (and
friends) to create the subsetted font file.

Now the latter expect the notdef glpyh to be encoded '0' (which is reasonable),
but do not allow for the encoding to be unsorted.

So there are three places where the encodig -> glyph could be repaired by
sorting: PSUploadFont (which has the original unsorted data), FontSubsetInfo
(which uses CreateT???FromTTFont wrongly) or the CreateT???FromTTFont functions,
which perhaps should be able to catch this.

@hdu: do you have an opinion where to best fix this ? I chose to use
CreatePSUploadableFont in glyphset.cxx for this since it is central and allows
to use the unsorted hash_map in the GlyphSet class (which is probably a
performance gain). Anyway I'd like you to review the change.

fixed in CWS vcl108

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to