To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=107450
------- Additional comments from m...@openoffice.org Wed Dec 9 16:04:07 +0000 2009 ------- There is horrible code that detects the "module field unit". It gets an SfxItemSet* as parameter and retrieves its SID_ATTR_METRIC item. In case no ItemSet is present (NULL pointer parameter), the "current SfxModule" is queried and the item is retrieved from it. I changed the method to get an SfxItemSet& and removed the code dealing with SfxModule. I added a new method SfxModule::GetModuleFieldUnit() in sfx2 so that every code that knows the module it is working with can use it directly. Only code that does not know anything about its content must use SfxModule::GetActiveModule() and so the same awful hack as now. But in future it is easy to spot these occurences and fix them by properly handing over context information to the code. Currently this hack is hidden behind an innocent interface. Fortunately the EditEngine/Outliner code always has an ItemSet, so we get rid of an sfx2 dependency here. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
