To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=108289
                 Issue #|108289
                 Summary|names of unmatched dependencies are not displayed anym
                        |ore in update dialog of extensions
               Component|framework
                 Version|DEV300m69
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|code
             Assigned to|dv
             Reported by|jl





------- Additional comments from [email protected] Wed Jan 13 15:43:37 +0000 
2010 -------
Install desktop/test/deployment/update/dependencies/update-dependencies.oxt
Then right-click on the new entry in the Extensions Manager and choose update.
Click "Show all" in update dialog and select the update for
update-dependencies.oxt. In the list box at the bottom is the text:

The extension cannot be updated because:
Required OpenOffice.org version doesn't match:
Unknown
Unknown
....


Initially there was something like:

Incompatibility:
name_of_the_dependency

This was obviously "improved" to better explain a version incompatibility. But
know all dependencies other than OpenOffice.org-minimal-version,
OpenOffice.org-maximal-version are just displayed as Unknown. 
This could be helped by changing the function getErrorText:
(diff based on DEV300m69)
--- a/desktop/source/deployment/misc/dp_dependencies.cxx        Tue Jan 12
15:55:12 2010 +0100
+++ b/desktop/source/deployment/misc/dp_dependencies.cxx        Wed Jan 13
16:32:36 2010 +0100
@@ -165,7 +165,8 @@
         sReason = ::rtl::OUString(
::String(::dp_misc::getResId(RID_DEPLYOMENT_DEPENDENCIES_MIN)) );
     }
     else
-        return ::rtl::OUString(
::String(::dp_misc::getResId(RID_DEPLYOMENT_DEPENDENCIES_UNKNOWN)) );
+        return name(dependency);
 
     if ( sValue.getLength() == 0 )
         sValue = ::rtl::OUString(
::String(::dp_misc::getResId(RID_DEPLYOMENT_DEPENDENCIES_UNKNOWN)) );


Then the error would read

The extension cannot be updated because:
Required OpenOffice.org version doesn't match:
  name_of_dependency
  ....
  You have OpenOffice.org 3.3.0

However, the name of the dependency does not fit in there because the line and
below refer to the version. I think it was supposed that only the  version
information appear between those lines. Those are not written in this function.

If there is an unknown dependency which is not matched then it should be
expressed clearly.

BTW, do not forget to update the specification.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to