To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=97421
User mst changed the following:
What |Old value |New value
================================================================================
CC|'redflagzhulihua' |'majun51,mst,redflagzhulih
| |ua'
--------------------------------------------------------------------------------
------- Additional comments from m...@openoffice.org Fri Feb 5 16:08:00 +0000
2010 -------
hi majun51,
i'm sorry, but your proposed change to ComparePosition is wrong:
try e.g. 2 positions with same start and end, which should return EQUAL, but
returns OUTSIDE.
It seems the return value of ComparePosition is not very well defined if start
and end of one range are equal; but i would recommend not changing
ComparePosition, because nobody knows what that may break.
While debugging i could see that there is a loop in SwDoc::AppendRedline for
such redlines with no extent.
It loops because the statement on line 923 "pRedl->SetStart" does not change the
redline.
Probably it would be better to just change the specific case in
SwDoc::AppendRedline that loops, by checking in the POS_INSIDE case if one of
the ranges is a point.
This has the advantage that it is unlikely to break any unrelated functionality.
Of course this has the disadvantage that it makes AppendRedline even more
complicated, but i cannot think of a better approach.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
