To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=109129


User fheckl changed the following:

                What    |Old value                 |New value
================================================================================
                  Status|RESOLVED                  |REOPENED
--------------------------------------------------------------------------------
              Resolution|FIXED                     |
--------------------------------------------------------------------------------




------- Additional comments from fhe...@openoffice.org Fri Feb 12 19:20:46 
+0000 2010 -------
I did further tests with this and can only say: Thank God that we first check 
if the filename is a directory. I 
compiled a simple test app to compare times using NSFileManager vs 
NFileWrapper. I only succeeded for 
small directories in my home folder. For larger directories it always crashed 
because it couldn't allocate 
enough memory.
So it may only be a real problem if directories on an SMB volume might not be 
detected by NSFileManager to 
be directories or if you have a symbolic link to a large directory.

However I do have one issue with your patch: You should never call 
isMemberOfClass for an NSString. 
Foundation is too complex for this to be successful :)
Please use isKindOfClass instead.
Therefore I reopen this issue so you can change it.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@porting.openoffice.org
For additional commands, e-mail: issues-h...@porting.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to