To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=110208
------- Additional comments from m...@openoffice.org Mon Mar 22 20:32:07 +0000 2010 ------- As I was guilty of breaking this: usually I'm working with nonpro versions, unfortunately I switched to a pro after the final resync because the Linux nonpro of the milestone (m69) was broken somehow (smoketest failed on all build bots). So some changes didn't get the additional testing provided by our debugging abilities in nonpro build s and I didn't catch that error. Sorry for that. I promise to go the extra mile next time and rather fix the broken nonpro version than doing without it. BTW: having code relying on a fixed order of IDs that are given by "#define"-s is a contradiction. I know that this stone old code in sfx2 was written that way to get the best performance (sorted IDs allow for a binary search), but IMHO we wouldn't lose a lot of performance by using unsorted arrays. At the end we are talking about integer arrays with a number of IDs between 5 and 20 or so and the code is not used for performance critical stuff, only for UI interactions that will work fast enough even without such peephole optimizations. BTW II: For the same reasons I consider the API of ItemSets with sorted "WhichRanges" as broken by design. Nevertheless thanks for spotting (and fixing) this problem. Until we haven't fixed the broken APIs, we still must fix problems like this one by changing code each time when a "#define" is changed. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
