To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=110771
Issue #|110771
Summary|sw: deferenced pointer and then checking it for NULL
Component|Word processor
Version|DEV300m76
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|ama
Reported by|cmc
------- Additional comments from c...@openoffice.org Sat Apr 10 19:49:51 +0000
2010 -------
in sw/source/core/frmedt/feshview.cxx we have...
SdrObject *pTmpObj = rMrkList.GetMark( i )->GetMarkedSdrObj();
BOOL bForget = pTmpObj->ISA(SwVirtFlyDrawObj);
if( bForget )
{
pDView->UnmarkAll();
if ( pTmpObj )
pDView->MarkObj( pTmpObj, Imp()->GetPageView(), bAddSelect, bEnterGroup );
else
pDView->MarkObj( rPt, MINMOVE );
it clearly doesn't make sense to do that "if (pTmpObj)" seeing as we already
deferenced pTmpObj. So either the else branch can go, or we should be checking
for a null pTmpObj earlier
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
