To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112319
Issue #|112319
Summary|update_tree.pl sets source_dir to "", effectively call
|ing »find /text«
Component|l10n
Version|DEV300m80
Platform|All
URL|
OS/Version|Unix, X11
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|code
Assigned to|ihi
Reported by|cloph
------- Additional comments from cl...@openoffice.org Fri Jun 11 21:14:55 +0000
2010 -------
update_tree.pl contains:
60 if ( ! defined $prj ) {
[...]
84 } else {
85 $tree_src = "$prj\/source\/auxiliary";
86 $tree_dest = "$prj\/$destpath\/misc";
* 87 $source_dir = "$prj\/source";
88 $source_dir_xhp = "$prj\/source";
89 $treestrings = "$source_dir/text/shared/tree_strings.xhp";
90
91 if( defined $ENV{LOCALIZATION_FOUND} && $ENV{LOCALIZATION_FOUND} eq
"YES" )
92 {
* 93 $source_dir = $ENV{TRYSDF};
94 }
95 else
96 {
**** 97 $source_dir = $ENV{LOCALIZESDF};
98 }
99 $source_dir =~ s/\/auxiliary\/localize.sdf$// ;
* 100 #else {die "ERROR: The env variables TRYSDF LOCALIZATION_FOUND
LOCALIZESDF not found ... something is wrong!\n";}
101
102 }
problematic lines marked with *
A) It's set to some value, just to be definitely set to another one. This IMHO
is bad style and confusing at best.
B) It doesn't bother to check whether the environment variables it attempts to
use are actually defined / contain something useful. That is the fatal thing
and
leads to
Reading localized titles... in /text
find: /text: No such file or directory
done reading a total of 0 localized titles for 0 languages from 0 files
in the build log
The codepath abote (when $prj is not defined) contains a check
if ( defined $ENV{TRYSDF} || defined $ENV{LOCALIZESDF} )
before using the environement variables.
C) Why is there such a love for commented-out code-statements in OOo,
especially
in perl-stuff involved in building. Either it is a fatal error, or it is not.
Having such statements commented out in the code again just adds confusion.
Have the balls to die if your assertions are not fulfilled. Much better than
ending up with broken state like it is the state currently.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@l10n.openoffice.org
For additional commands, e-mail: issues-h...@l10n.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
