To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395
------- Additional comments from m...@openoffice.org Thu Jul 29 11:18:25 +0000 2010 ------- oops, completely forgot about this :) re: PTRARR_DEL: it seems that replacing with shared_ptr is indeed mostly straightforward, except in one case: if Remove() is called on a PTRARR_DEL, then it seems the removed object will NOT be deleted, while removing an object from an STL container would invoke the shared_ptr destructor. (but that case doesn't seem to occur in the current patch.) oh, and the implementation of Replace() also doesn't seem to invoke the destructor, but i'm hoping that Replace() is not used much (and guessing that whenever it's used on a PTRARR_DEL currently it's a memory leak ;) ). so i think the patch is good now, thanks for fixing the problems. you've created a cws "svarray"; please commit your patch there and push. oh, and you should add this issue to the CWS: log into EIS, click on "tasks", and then "add task". if you want the ugly STOP sign on the EIS CWS page (which our tooling people seem to think of as a great motivational tool that really makes a good impression on new developers...) to go away then you need to edit the CWS data in EIS (click on the "DEV300/svarray" link) and set the Release to "OOo 3.4". --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
