To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=93503
------- Additional comments from e...@openoffice.org Tue Aug 3 10:51:28 +0000 2010 ------- @tantai_thanakanok: Thanks, some nitpicks though: 0. Please always attach diffs as files of type text/patch, pasting diffs to the comment field may introduce unintended line breaks and other quirks. 1. The patch removes the Thai T NatNum modifier exported as t to Excel, that is unacceptable. This modifier is a specialty of the Thai Excel version we import and export. Any specific reason you removed that? 2. When encountering NF_SYMBOLTYPE_CALDEL there is no need to additionally check for "[~", NF_SYMBOLTYPE_CALDEL is only set for that context. For import the number format scanner/parser is used, see svl/source/numbers/zforscan.cxx with the strategic entry point ImpSvNumberformatScan::ScanFormat() Be warned, that is hard stuff ;-) Btw, I suggest you use a recent DEV300 milestone for development, things are quite changing between releases and the number formatter isn't even in module svtools anymore but in svl instead. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
