To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113663





------- Additional comments from zhangjf...@openoffice.org Fri Aug  6 05:37:27 
+0000 2010 -------
Thank you for your quick fix.

Since I only have 31M11 build environment, so I migrate the 3 patches' code to
my code base and try a new build,  the result is,
  .  open/close an odt document,  the CDocument object is freed normally
  .  open/save/close an odt doc,  the CDocument object is not freed. The removed
child nodes do get freed.  I guess there are still some attribute nodes are not
freed.

I am not sure if I missed something, please help to check it in your 
environment.

There are several concerns about the patches,
  1.  Removing child node means removing a DOM sub tree, we'd also take care of
it's children nodes because they in fact are orphaned nodes too.
  2.  We met a very special cases before. UNOXML creates several CNode for a
single libxml DOM node. In that case, if we freed the m_aNodePtr in first CNode,
then we may get trouble when freeing the second CNode.  This case can be
recreated by these steps with OOo 3.1M11 build.
      . open the attached sample file 
      . Select some text in one table cell, and change it to bold text.
      . Then save and close the document
I am not sure if still can be recreated with 321 code and these patches.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org
For additional commands, e-mail: issues-h...@framework.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to