To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=113743
------- Additional comments from i...@openoffice.org Tue Aug 10 15:05:44 +0000 2010 ------- @zhangjfibm, first thanks for providing a second patch! There are a few issues. The patch does not compile out of the box in the OOo environment with warning==errors because of 'unused parameter' warning for parameter xListener and a 'signed/unsigned mismatch' warning within the for-loop with a sal_Int32 index variable for a vector. The second can be avoided by using an iterator instead. I also would shorten the namespaces within the c++ files. Having done that changes the patch does fix the obvious memory leak. When the attached example document is opened the DataPoint constructor is reached 18 times and when the document is closed the destructor is reached 18 times too now! Thats good. I will check next week whether there are some not so obvious scenarios where the leak still exist - e.g. removing a series via dialog or API. Thanks again for the patch and for pointing out the problem! --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@graphics.openoffice.org For additional commands, e-mail: issues-h...@graphics.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
