To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113152


User mst changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'mst,os'                  |'mba,mst,os'
--------------------------------------------------------------------------------
             Assigned to|mst                       |mba
--------------------------------------------------------------------------------




------- Additional comments from m...@openoffice.org Thu Oct 21 13:16:40 +0000 
2010 -------
relevant diff:

-        if((SID_INSERT_APPLET == nSlot || SID_INSERT_PLUGIN)
-                && (pClassItem || pClassLocationItem || pCommandsItem))
+        if( pClassItem || pClassLocationItem || pCommandsItem )

this does the same thing as before, but the point of this issue was that
that was wrong  :)

if you look at the case labels before this if, there is another nSlot
that lands here, SID_INSERT_OBJECT.
so imho it should be "if ((SID_INSERT_PLUGIN == nSlot) && (...||..||...))"

_unless_ you say the code in the if should be executed
for SID_INSERT_OBJECT as well.
since i can't tell the difference between SID_INSERT_OBJECT and my elbow,
i have no opinion on that  :)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org
For additional commands, e-mail: issues-h...@sw.openoffice.org


---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org

Reply via email to