To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=93503
------- Additional comments from samp...@openoffice.org Thu Dec 2 04:29:39
+0000 2010 -------
> 2. I don't like the change made to SvNumberformat::ImpNextSymbol()
Corrected in the updated version of the patch.
> Anyhow, using the number formatter dialog and setting the Language to Thai and
> trying to use the code
> [$-D07041E]0
> and pressing the green check mark button does not accept the code. If
> I understood correctly that should result in
> [$-41E][~buddhist][NatNum1]0
I guess the example should actually be written as
[$-D07041E]dd/mm/yy
because the number format '0' doesn't make sense for date.
And the result, after applying the patch, will be
[$-41E][NatNum1][~buddhist]dd/mm/yy
Is this OK?
Since in the current implementation, you can't use the format
[$-41E][~buddhist][NatNum1]dd/mm/yy
at all. The number format dialog will accept the format code
if you enter it manually but after you click the green checkmark
but it will do nothing.
The sequence "[$-41E][~buddhist][NatNum1]dd/mm/yy" happens
to be illegal in the current implementation. Using the sequence
"[$-41E][NatNum1][~buddhist]dd/mm/yy" will produce the desired
effect. We can fix this but it require a lot more modifications.
> 3. I still don't agree to the removal or conversion of
>- // The Thai T NatNum modifier during Xcl export.
>- if (rNum.IsSet() && rNum.GetNatNum() == 1 &&
>- rKeywords[NF_KEY_THAI_T].EqualsAscii( "T") &&
>- MsLangId::getRealLanguage( rNum.GetLang()) ==
>- LANGUAGE_THAI)
>- {
>- aPrefix += 't';
>- }
The above code is modified as
+ // The Thai T NatNum modifier during Xcl export.
+ if (rNum.IsSet() && rNum.GetNatNum() == 1 &&
+ rKeywords[NF_KEY_THAI_T].EqualsAscii( "T") &&
+ MsLangId::getRealLanguage( rNum.GetLang()) ==
+ LANGUAGE_THAI && !LCIDInserted )
+ {
+
+ aStr.InsertAscii( "[$-D00041E]", 0 );
+ }
Which means that the filter will accept the number format "t0" (processed
elsewhere) from Excel and convert to "[$41E][NatNum1]0" in Calc.
When convert back to excel it will become "[$-D00041E]0" (not "t0")
which when import into Calc will become "[$41E][NatNum1]0" again.
The difference is that when export to Excel, the code will no longer generate
"t0" but the more correct (right?) "[$-D00041E]0".
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org
---------------------------------------------------------------------
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org
