To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=116612 Issue #|116612 Summary|solenv/gbuild/platform/linux.mk typos when linking exe |cutables Component|tools Version|DEV300m98 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|solenv Assigned to|sb Reported by|sb
------- Additional comments from s...@openoffice.org Tue Jan 25 18:04:27 +0000 2011 ------- I noticed three typos regarding linking of executables in solenv/gbuild/platform/linux.mk: <http://hg.services.openoffice.org/DEV300/file/3dc4b4b59914/solenv/gbuild/platform/linux.mk#l120> contains "-Wl,-rpath-link=..." instead of "-Wl,-rpath-link,..." (which appears to be harmless, as GNU ld appears to treat -rpath-link=... the same as -rpath-link xxx, but still). <http://hg.services.openoffice.org/DEV300/file/3dc4b4b59914/solenv/gbuild/platform/linux.mk#l120> adds $(SOLARLIBDIR) to -rpath-link, which is not defined in the new build system. However, the new build system's corresponding $(gb_Library_OUTDIRLOCATION) is already added to -rpath-link at <http://hg.services.openoffice.org/DEV300/file/3dc4b4b59914/solenv/gbuild/platform/linux.mk#l268> and <http://hg.services.openoffice.org/DEV300/file/3dc4b4b59914/solenv/gbuild/platform/linux.mk#l313>, so the $(SOLARLIBDIR) can simply be dropped. <http://hg.services.openoffice.org/DEV300/file/3dc4b4b59914/solenv/gbuild/platform/linux.mk#l312> uses gb_Library_get_layer instead of gb_Executable_get_layer in the definition of gb_Executable_get_rpath, so that the resulting RPATH of executables is empty. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@tools.openoffice.org For additional commands, e-mail: issues-h...@tools.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
