To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=48783
------- Additional comments from [EMAIL PROTECTED] Wed May 11 02:27:32 -0700
2005 -------
Ah, it's better to test the rpm ...
Four final issues:
1)openofficeorg-mandriva-menus should probably obsolete/provide
openofficeorg-mandrakelinux-menus?
2)The %{update_menus}/%{clean_menus} macros aren't being substituted:
$ rpm -qp --scripts openofficeorg-mandriva-menus-1.9.95-1.noarch.rpm |grep ^%
%{update_menus}
%{clean_menus}
Maybe you should use a local conditional macro defition, something like this
should work:
%{?!update_menus:%define update_menus if [ -x /usr/bin/update-menus ]; then
/usr/bin/update-menus || true ; fi}
%{?!clean_menus:%define clean_menus if [ "$1" = "0" -a -x /usr/bin/update-menus
]; then /usr/bin/update-menus || true ; fi}
3)%update_menus should probably be run in a triggerin for any package listed in
the ?package(), and %clean_menus in a triggerun (or, maybe triggerpostun
rather). Something like this should be ok:
%triggerin -- openofficeorg openofficeorg-calc openofficeorg-draw
openofficeorg-impress openofficeorg-writer openofficeorg-math
openofficeorg-core02
%{update_menus}
%triggerpostun -- openofficeorg openofficeorg-calc openofficeorg-draw
openofficeorg-impress openofficeorg-writer openofficeorg-math
openofficeorg-core02
%{clean_menus}
4)In the package attached, it seems there are two menu entries for each
"GenerateMenu" call in the spec file, maybe %{_menudir}/%{name} should be
emptied first ... (since you can't 'rm -Rf %{buildroot}').
Otherwise, it looks good.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
