To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=50817
User jb changed the following:
What |Old value |New value
================================================================================
Assigned to|jb |obr
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Thu Jun 16 07:27:10 -0700
2005 -------
@obr: that is your component, so please take over the review.
I have done a quick, rather superficial review. Some comments:
This patch could simplify some things by uniting all the different layers into
one class and making the operation more data driven. OTOH there may be a slight
runtime overhead associated with that.
A more performance-critical point is the generation of timestamps. That code
should use the component parameter as filter to make only those settings part of
the hash that belong to the current component. This avoids unnecessary gconf
accesses and unnecessary remerges due to irrelevant stamp changes.
I don't think the code to handle dependencies between settings belongs at this
level - but I also haven't checked exactly what it does and under what
circumstances. You should document more clearly what this dependency should
express.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
