To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=50817





------- Additional comments from [EMAIL PROTECTED] Mon Jul 18 03:00:14 -0700 
2005 -------
This patch looks much better. I still could imagine some improvements like using
function pointers (or even better: C++ function objects) instead of a
boolean/enum combination to accomplish all the special casing, but I wouldn't
say this is a "must fix before you can integrate". So it is up to you if you
want the code to improve any further.

I will be on a two week vacation starting tomorrow. In case you want to keep the
code as it is, I plan to make some regression tests as soon as I return.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to