To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=45333





------- Additional comments from [EMAIL PROTECTED] Mon Aug 15 04:28:55 -0700 
2005 -------
flr:
The problems is, that the SwRead pRead variable in SwDocShell::ConvertFrom
retieved by SwDocShell::StartConvertFrom is a reference to a "static" object
reference and the members of this reference are modified during import. 
In case of a Word document which contains a word OLE the SwDocShell::ConvertFrom
is called twice; once for the Word document and once for the Word OLE. The
second call to SwDocShell::ConvertFrom modified the pStg variable of the
"static" SwRead reference and thus the outer SwDocShell::ConvertFrom call 
crashed.
I solved this problem by storing a copy of pStg when entering
SwDocShell::ConvertFrom and setting back the saved pStg contents when exiting
SwDocShell::ConvertFrom.
This can be seen as a kind of "hack" which cures the symptons, but does not
eliminate the bad design of having a "static" SwRead reference, but after a
discussion with od we decided to go this way, since a redesign is not possible 
now.


Modified files in cws javapatch:
Checking in docsh.cxx;
/cvs/sw/sw/source/ui/app/docsh.cxx,v  <--  docsh.cxx
new revision: 1.52.40.1; previous revision: 1.52
done
Checking in shellio.hxx;
/cvs/sw/sw/inc/shellio.hxx,v  <--  shellio.hxx
new revision: 1.28.334.1; previous revision: 1.28
done


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to