My understanding was that the root cause here was the markdown text that 
*Allura* uses to construct the email uses `---` which creates a `<h2>`, not 
that there was an `<h2>` in the user's input.

That said, I noticed on this ticket we have `<h2>` in summary line and it ends 
up rendering as a real `<h2>` in email notifications.  We should allow `<h2>` 
in markdown, it is useful; but we could keep titles/summary lines as 
non-markdown since they are are just a single line and people don't really put 
markdown into a ticket summary or forum thread title.  I'm guessing this would 
be a matter of escaping the summary line when inserting it into the email 
notification.


---

** [tickets:#5693] Last paragraph in Allura notification mails about forum 
posts is <h2> in HTML**

**Status:** in-progress
**Labels:** 42cc 
**Created:** Fri Jan 25, 2013 10:01 PM UTC by Michalis Kamburelis
**Last Updated:** Thu Jun 27, 2013 07:23 AM UTC
**Owner:** nobody

When sending notification mails about forum posts, Allura appends at the end 
text like

~~~~
---
[thread title](thread link)
~~~~

This means that the paragraph above will be accidentally processed by Markdown 
as a header (< h2 >).

For example, consider this discussion thread 
https://sourceforge.net/p/castle-engine/discussion/general/thread/e17a79e1/ . 
The last paragraph of 2nd post says "I also fixed the deprecated usage of 
CreateCamera that you can see mentioned in FPC messages."

Now when Allura sends me a notification mail about this forum post, it looks 
like this in text version:

~~~~
I also fixed the deprecated usage of CreateCamera that you can see mentioned in 
FPC messages.
---
[Error compiling SVN example with "make 
examples"](https://sourceforge.net/p/castle-engine/discussion/general/thread/e17a79e1/?limit=25#c927)

---

Sent from sourceforge.net because you indicated interest in 
<https://sourceforge.net/p/castle-engine/discussion/general/>

To unsubscribe from further messages, please visit 
<https://sourceforge.net/auth/prefs/>
~~~~

And like this in HTML version:

~~~~
<h2 id="...">I also fixed the deprecated usage of CreateCamera that you can see 
mentioned in FPC messages.</h2>
<p><a class="" 
href="https://sourceforge.net/p/castle-engine/discussion/general/thread/e17a79e1/?limit=25#c927";>Error
 compiling SVN example with "make examples"</a></p>
<hr />
<p>Sent from sourceforge.net because you indicated interest in <a 
href="https://sourceforge.net/p/castle-engine/discussion/general/";>https://sourceforge.net/p/castle-engine/discussion/general/</a></p>
<p>To unsubscribe from further messages, please visit <a 
href="https://sourceforge.net/auth/prefs/";>https://sourceforge.net/auth/prefs/</a></p></div>
~~~~

The HTML version of the email was obviously prepared by processing text version 
with Markdown. And the "---" (appended automatically by Allura) caused the 
paragraph "I also fixed the deprecated usage" to be surrounded by < h2 >, since 
this is how you make headers using Markdown.

A trivial solution would probably be to just add a newline before the "---" 
that is appended by Allura.


---

Sent from sourceforge.net because [email protected] is subscribed 
to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.

Reply via email to