* `Allura/allura/templates/login_fragment.html` is missing * It might be a side-effect of the missing template, but the login overlay box appears at the bottom of the page, not floating above the main content, and the main content isn't grayed out at all. * why is `require_access` needed in the `process()` method since it's already happening in `_check_security`? Is it because _check_security is running but merely doing an overlay and not blocking the request? That is a little unsettling. We'll have to be careful when we use login_overlay within _check_security. * Somethings sits wrong with me when I see `lib/security.py` setting `c.show_login_overlay`. I'm not sure exactly how to make it better though. Instead of `require[_access]` functions doing it, the controller could catch `HTTPUnauthorized` and set `c.show_login_overlay`. I think it's a little better to have that in the controller layer, but then we have a few lines of boilerplate in every controller that uses it. A helper function could do it? But that is starting to seem silly since it's just a few lines of code right now. * tests?
--- ** [tickets:#6529] Login overlay** **Status:** in-progress **Labels:** import auth **Created:** Wed Aug 07, 2013 08:36 PM UTC by Cory Johns **Last Updated:** Wed Sep 11, 2013 04:56 PM UTC **Owner:** Cory Johns Create a decorator or `require_access` alternative that allows the page to render but causes a login overlay dialog to be displayed over the page, similar to [this mockup](http://rhaynie-4185.sb.sf.net/Slashdesign/SFlogin/overlay/login-overlay.html). The overlay should load an iframe from the URL specified in `auth.login_fragment_url` with the appropriate `return_to` info provided, which should submit to `_top` to reload the source page. Also, the overlay should be a little lighter than the mockup and the box should be movable so that the underlying page can be inspected (although not interacted with) as the purpose behind this is to showcase what can be done when logged in. A default fragment implementation should be provided based on the default login view in `allura.controllers.auth.AuthController`. A SFX fragment implementation will need to be created, as well, for SF. --- Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
