~~~~~
::python
if isinstance(references, list):
    references = [u'<%s>' % r for r in references]
else:
    references = [references]
~~~~~

There seems to be a disagreement there as to whether the angle-brackets should 
be added.  Additionally, I think `paste.deploy.converters.aslist()` could be 
used here to simplify that.  Something like:

~~~~~
::python
references = [u'<%s>' % r for in aslist(references)]
~~~~~

Can you please make that change, if it's correct, and add a test case to 
`Allura/allura/tests/test_tasks:TestMailTasks` for this change (there's one 
there for the `Sender` header that you could base it off of).


---

** [tickets:#6328] Use In-Reply-To: and References: headers for outgoing ticket 
emails**

**Status:** code-review
**Labels:** 42cc 
**Created:** Tue Jun 04, 2013 02:04 PM UTC by Hanspeter Niederstrasser
**Last Updated:** Fri Nov 01, 2013 05:16 PM UTC
**Owner:** nobody

Outgoing ticket emails should use the In-Reply-To: and References: headers so 
that recipient user agents can group messages from the same ticket together.

For example, e-mails from Canonical's Launchpad tracker use the Message-ID of 
the original post in the References: field of follow up posts.  The same should 
happen with SF ticket e-mails.  In case a user replies via e-mail or using the 
"Reply" button on the web interface, the Message-ID of the 'parent' message 
should be appended to the In-Reply-To: and References: headers.


---

Sent from sourceforge.net because [email protected] is subscribed 
to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.

Reply via email to