Looking good.  Few things though:

It seems that the `@macro` decorator is sufficient to register the macro, but 
we need an entry point to ensure the module gets loaded and registering 
happens.  But then we don't use the entry points.  Seems a little odd, but I'm 
not sure how to improve.

In test_globals.py it still checks for 'download-button' and no longer passes.

The nbhd macro `[[projects display_mode=list]]` includes the 
`[[download_button]]` macro, which ends up being spit out as plain HTML text.  
I don't want to go down a rabbit trail on this particular ticket, but perhaps 
we should just make `show_download_button` default to 'no' instead of 'yes' for 
better default behavior (the Neighborhood Help text should be updated with the 
new default too).

Can we get some docs?  `extending.rst` should cover this.


---

** [tickets:#6393] Allow plugins to register new markdown macros**

**Status:** in-progress
**Created:** Tue Jun 25, 2013 04:39 PM UTC by Tim Van Steenburgh
**Last Updated:** Tue Jan 14, 2014 08:36 PM UTC
**Owner:** Tim Van Steenburgh

Right now all of our markdown macros are defined in Allura core, even those 
that are tool-specific. We should provide a way for plugins to register their 
own macros with the platform.


---

Sent from sourceforge.net because [email protected] is subscribed 
to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.

Reply via email to