Takashi Iwai wrote: > > > > > The _norms function appears to be badly broken (_min and _max > > interchanged, using 32/64 bits for 24/32 bit values). I didn't attempt > > to fix it as it isn't used, either.
min & max are interchanged indeed. My bad... Use of 32/64 bits for 24/32 bit is wanted. Take in account that this function is called on mix results (where I need to avoid wrap before normalization). > > yes. we can remove this stuff. > Jaroslav, any plan to use still this one? Please don't remove it. I've written it for pcm_mix. Maybe one day I'll find the time to finish it. > > > And the summing/normalization code in pcm_route.c treats the sample as > > if it were unsigned. > > nice spot. Be careful here. Use of signed vs. unsigned was an hard decision. Can you point me exactly where you see a problem? -- Abramo Bagnara mailto:[EMAIL PROTECTED] Opera Unica Phone: +39.546.656023 Via Emilia Interna, 140 48014 Castel Bolognese (RA) - Italy ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Oh, it's good to be a geek. http://thinkgeek.com/sf _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
