Martin Langer wrote: > On Wed, Jul 31, 2002 at 12:26:33PM +0200, Clemens Ladisch wrote: > > > > IMHO the garbled device name is strange, too. ;-) This is a (rather > > harmless) buffer overflow which has been fixed by the latest version of my > > other patch. > > Rather harmless buffer overflows results in segfaults - a tough ideology!
It was the uninitialized variable which caused the segfault, the buffer overflow only garbled the long name. > Finally there is only one point, which doesn't show perfect beauty. It's the > shortname of the proc entry, which looks incomplete, > > 3 [card3 ]: USB MIDI - Evolution Electronics Ltd. MK-2 > Evolution Electronics Ltd. MK-249C USB MIDI keyboard at > 001/002 if 1 ALSA limits the length of the shortname to 32 bytes (hence _short_name). You already know what happens if the shortname isn't restricted to that size. ;-) Clemens ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
