> I read up on timers, and fixed that problem too. This is an updated
> patch, and I'm happy to say that the tumbler now works perfectly :)
And one last addition (I hope).
<< 4 isn't enough volume at the top. Reading the TAS3001C docs I came
across a huge table, which I implemented, and which made the volume much
too loud. I also tried using << 11, which is a linear progression
through the entire range, and this is also too loud (the first setting
is already loud).
I found that << 6 gives the right balance. It can be really quiet, to
fairly loud.
I suggest committing this change, possibly with a note saying that
feedback is welcome if anyone things this setting is note quite right.
Also, the linuxppc guys said something about Darwin's volume tables
being different for different machines, for instance, it's apparently
different for the new Ti books (compared to these values which are for
ibook2).
Please find the patch attached.
jack.
Index: cards/ppc/tumbler.c
===================================================================
RCS file: /cvsroot/alsa/alsa-driver/cards/ppc/tumbler.c,v
retrieving revision 1.4
diff -u -r1.4 tumbler.c
--- cards/ppc/tumbler.c 2001/09/07 13:41:11 1.4
+++ cards/ppc/tumbler.c 2001/12/07 06:31:34
@@ -72,8 +72,8 @@
if (! mix->i2c.base)
return -ENODEV;
- left_vol = mix->left_vol << 4;
- right_vol = mix->right_vol << 4;
+ left_vol = mix->left_vol << 6;
+ right_vol = mix->right_vol << 6;
if (left_vol > TAS_VOL_MAX)
left_vol = TAS_VOL_MAX;
