[Alsa-devel] [PATCH] unused code in rawmidi.c

[Clemens Ladisch]

SNDRV_RAWMIDI_IOCTL_PARAMS doesn't return data, and err isn't initialized.
But the code wasn't used anyway ...


--- alsa-kernold/core/rawmidi.c Thu Nov 07 11:56:06 2002
+++ alsa-kernel/core/rawmidi.c  Thu Nov 07 12:07:37 2002
@@ -699,7 +699,6 @@
        case SNDRV_RAWMIDI_IOCTL_PARAMS:
        {
                snd_rawmidi_params_t params;
-               int err;
                if (copy_from_user(&params, (snd_rawmidi_params_t *) arg, 
sizeof(snd_rawmidi_params_t)))
                        return -EFAULT;
                switch (params.stream) {
@@ -714,9 +713,6 @@
                default:
                        return -EINVAL;
                }
-               if (copy_to_user((snd_rawmidi_params_t *) arg, &params, 
sizeof(snd_rawmidi_params_t)))
-                       return -EFAULT;
-               return err;
        }
        case SNDRV_RAWMIDI_IOCTL_STATUS:
        {



-------------------------------------------------------
This sf.net email is sponsored by: See the NEW Palm 
Tungsten T handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0001en
_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel