Hi Steven,

On Wed, Aug 25, 2010 at 3:42 PM, Steven Backus
<bac...@whimsy.med.utah.edu> wrote:
> Dustin and Jean-Louis are both on vacation, Dustin asked me to look
> into this further.  Here's the pertinent log:
>
> Tue Aug 24 23:59:10 2010: amreport: pid 31955 ruid 0 euid 0 version 3.1.2: 
> start at Tue Aug 24 23:59:10 2010
> Tue Aug 24 23:59:10 2010: amreport: pid 31955 ruid 0 euid 0 version 3.1.2: 
> rename at Tue Aug 24 23:59:10 2010
> Tue Aug 24 23:59:10 2010: amreport: using logfile: /usr/adm/amanda/gen/log
> Tue Aug 24 23:59:10 2010: amreport: operating in script mode
> Tue Aug 24 23:59:10 2010: amreport: warning: Use of uninitialized value in 
> substitution (s///) at /usr/lib/perl5/site_perl/5.8.8/Amanda/Report.pm line 
> 856.
>
> Tue Aug 24 23:59:10 2010: amreport: planned output: human mail root
> Tue Aug 24 23:59:10 2010: amreport: planned output: postscript 
> /local/etc/amanda/gen/3hole.ps printer SteveLaser
> Tue Aug 24 23:59:10 2010: amreport: invoking mail app: /usr/bin/Mail -s gen 
> FAIL: AMANDA MAIL REPORT FOR August 23, 2010 root
> Tue Aug 24 23:59:10 2010: amreport: warning: Use of uninitialized value in 
> numeric gt (>) at /usr/lib/perl5/site_perl/5.8.8/Amanda/Report/human.pm line 
> 608.
>
> Tue Aug 24 23:59:10 2010: amreport: warning: Argument "-- " isn't numeric in 
> numeric eq (==) at /usr/lib/perl5/site_perl/5.8.8/Amanda/Report/human.pm line 
> 1312.

Well, for some reason, $orig_size ends up set to zero which causes
Amanda::Report::Human::divzero_col to return a string (-- )rather than
a numeric.

Never having read this code before and so shooting from the hip, I'd
say the code does not handle the case where orig_kb == 0. Since
divzero_col "could" return a non-numeric value, at the very least, the
conditionals at lines 1289 and 1312 in Human.pm should be modified to
take in to count the possibility of a non-numeric value in their test.

However, there looks to have been substantial changes to other parts
of the code, so the true problem may lie farther back up the food
chain.

Kind Regards,
Chris

Reply via email to