Do not change g_thread_create_new by g_thread_new, the are not the same API.
You only get warning, keep g_thread_create.
Jean-Louis
On 03/10/2012 07:05 PM, gene heskett wrote:
On Saturday, March 10, 2012 06:53:26 PM Jean-Louis Martineau did opine:
On 03/10/2012 10:43 AM, gene heskett wrote:
On Saturday, March 10, 2012 10:07:37 AM Jean-Louis Martineau did opine:
Amanda do not use its own implementation of g_queue_free_full, so it
can be removed with the attached patch.
Jean-Louis
Patch not yet complete, Jean-Louis
Now it will build and install, but I did see a warning go by at about
200 mph during the make, and amcheck now bails on this:
Amanda Tape Server Host Check
-----------------------------
Holding disk /usr/dumps: 415024 MB disk space available, using 414524
MB **
ERROR:glib-util.c:45:glib_init: assertion failed:
(!g_thread_supported()) amcheck-device terminated with signal 6Server
check took 0.087 seconds
Remove that line from the code: common-src/glib-util.c line 45.
Jean-Louis
How about in xfer-test.c? It is still complaining. Fixed that, then fixed
amsemaphore-test.c by changing the create to new, but that then fails with:
amsemaphore-test.c: In function ‘test_decr_wait’:
amsemaphore-test.c:59:5: warning: passing argument 1 of ‘g_thread_new’ from
incompatible pointer type
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘const gchar *’
but argument is of type ‘void * (*)(void *)’
amsemaphore-test.c:59:5: warning: passing argument 3 of ‘g_thread_new’
makes pointer from integer without a cast
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘gpointer’ but
argument is of type ‘int’
amsemaphore-test.c:59:5: error: too many arguments to function
‘g_thread_new’
/usr/include/glib-2.0/glib/gthread.h:142:11: note: declared here
amsemaphore-test.c: In function ‘test_wait_empty’:
amsemaphore-test.c:109:5: warning: passing argument 1 of ‘g_thread_new’
from incompatible pointer type
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘const gchar *’
but argument is of type ‘void * (*)(void *)’
amsemaphore-test.c:109:5: warning: passing argument 3 of ‘g_thread_new’
makes pointer from integer without a cast
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘gpointer’ but
argument is of type ‘int’
amsemaphore-test.c:109:5: error: too many arguments to function
‘g_thread_new’
/usr/include/glib-2.0/glib/gthread.h:142:11: note: declared here
amsemaphore-test.c: In function ‘test_force_adjust’:
amsemaphore-test.c:153:5: warning: passing argument 1 of ‘g_thread_new’
from incompatible pointer type
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘const gchar *’
but argument is of type ‘void * (*)(void *)’
amsemaphore-test.c:153:5: warning: passing argument 3 of ‘g_thread_new’
makes pointer from integer without a cast
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘gpointer’ but
argument is of type ‘int’
amsemaphore-test.c:153:5: error: too many arguments to function
‘g_thread_new’
/usr/include/glib-2.0/glib/gthread.h:142:11: note: declared here
amsemaphore-test.c: In function ‘test_force_set’:
amsemaphore-test.c:200:5: warning: passing argument 1 of ‘g_thread_new’
from incompatible pointer type
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘const gchar *’
but argument is of type ‘void * (*)(void *)’
amsemaphore-test.c:200:5: warning: passing argument 3 of ‘g_thread_new’
makes pointer from integer without a cast
/usr/include/glib-2.0/glib/gthread.h:142:11: note: expected ‘gpointer’ but
argument is of type ‘int’
amsemaphore-test.c:200:5: error: too many arguments to function
‘g_thread_new’
/usr/include/glib-2.0/glib/gthread.h:142:11: note: declared here
make[3]: *** [amsemaphore-test.o] Error 1
So I'm in over my head. :(
Cheers, Gene
