Hi,

* Jean-Louis Martineau <jmartin...@carbonite.com> [20161114 12:00]:
> Try the attached patch.

That seemed to have done it. So far so good and still going but looking
good. Smaller block size used here compared to what I used before with
hw compression on so it doesn't compare directly with what I had before.


~amanda/sbin/amtapetype -f -b 256k -t tape-lto6 /dev/nst0
Checking for FSF_AFTER_FILEMARK requirement
Applying heuristic check for compression.
Wrote random (uncompressible) data at 28406877.0909091 bytes/sec
Wrote fixed (compressible) data at 156237824 bytes/sec      
Compression: enabled
Writing one file to fill the volume.
Wrote 2518892150784 bytes at 130857 kb/sec                  
Writing smaller files (25188892672 bytes) to determine filemark.
File 17, block 54320        

Thanks Jean-Louis!
jf

> 
> Jean-Louis
> 
> On 14/11/16 10:06 AM, Jean-Francois Malouin wrote:
> >Hi,
> >
> >Amanda-3.4 and a new LTO6 tape library:
> >
> >~amanda/sbin/amtapetype --version
> >amtapetype-3.4
> >
> >~amanda/sbin/amtapetype -b 2048k -t tape-lto6 -f /dev/nst1
> >Checking for FSF_AFTER_FILEMARK requirement
> >amtapetype: Error setting FSF_AFTER_FILEMARK: Success at 
> >/opt/amanda/sbin/amtapetype line 372.
> >
> >Any ideas?
> >
> >The 3.3.6 version happily produced an tapetype entry:
> >
> >/usr/sbin/amtapetype --version
> >amtapetype-3.3.6
> >
> >/usr/sbin/amtapetype -b 2048k -t tape-lto6 -f /dev/nst1
> >
> >define tapetype tape-lto6 {
> >     comment "Created by amtapetype; compression disabled"
> >     length 2459914240 kbytes
> >     filemark 3227 kbytes
> >     speed 156832 kps
> >     blocksize 2048 kbytes
> >}
> ># LEOM is not supported for this drive and kernel
> >
> >
> >Thanks,
> >jf
> 
> 

> diff --git a/device-src/amtapetype.pl b/device-src/amtapetype.pl
> index d46fbc5..60f9475 100644
> --- a/device-src/amtapetype.pl
> +++ b/device-src/amtapetype.pl
> @@ -368,8 +368,10 @@ sub check_property {
>      $device->finish();
>  
>      #set fsf_after_filemark to false
> -    $device->property_set('FSF_AFTER_FILEMARK', 0)
> -         or die "Error setting FSF_AFTER_FILEMARK: " . 
> $device->error_or_status();
> +    my $r = $device->property_set('FSF_AFTER_FILEMARK', 0);
> +    if ($r) {
> +     die "Error setting FSF_AFTER_FILEMARK: $r";
> +    }
>  
>      my $need_fsf_after_filemark = 0;
>  
> @@ -420,8 +422,10 @@ sub check_property {
>      my $fsf_after_filemark_works = 0;
>      if ($need_fsf_after_filemark) {
>       #set fsf_after_filemark to true
> -     $device->property_set('FSF_AFTER_FILEMARK', 1)
> -         or die "Error setting FSF_AFTER_FILEMARK: " . 
> $device->error_or_status();
> +     $r = $device->property_set('FSF_AFTER_FILEMARK', 1);
> +     if ($r) {
> +         die "Error setting FSF_AFTER_FILEMARK: $r";
> +     }
>  
>       if ($device->read_label() != $DEVICE_STATUS_SUCCESS) {
>           die ("Could not read label from: " . $device->error_or_status());
> @@ -467,12 +471,18 @@ sub check_property {
>       if (defined $opt_property || $fsf_after_filemark) {
>           print STDOUT "device-property \"FSF_AFTER_FILEMARK\" \"false\"\n";
>       }
> -     $device->property_set('FSF_AFTER_FILEMARK', 0);
> +     $r = $device->property_set('FSF_AFTER_FILEMARK', 0);
> +     if ($r) {
> +         die "Error setting FSF_AFTER_FILEMARK: $r";
> +     }
>      } elsif ($need_fsf_after_filemark == 1 && $fsf_after_filemark_works == 
> 1) {
>       if (defined $opt_property || !$fsf_after_filemark) {
>           print STDOUT "device-property \"FSF_AFTER_FILEMARK\" \"true\"\n";
>       }
> -     $device->property_set('FSF_AFTER_FILEMARK', 1);
> +     $r = $device->property_set('FSF_AFTER_FILEMARK', 1);
> +     if ($r) {
> +         die "Error setting FSF_AFTER_FILEMARK: $r";
> +     }
>      } else {
>       die ("Broken seek_file");
>      }

Reply via email to