----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100129/#review280 -----------------------------------------------------------
Ship it! src/core-impl/meta/file/TagLibUtils.cpp <http://git.reviewboard.kde.org/r/100129/#comment225> Nice idea that. Maybe that could even be re-used for the reading part? src/core-impl/meta/file/TagLibUtils.cpp <http://git.reviewboard.kde.org/r/100129/#comment224> If why does replaceField not handle this? If it really doesn't handle this, can replaceField improved? For me it looks like the there is three times the same code. Summary: makes the code better so ship it. - Ralf On 2010-11-03 13:27:29, Sergey Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100129/ > ----------------------------------------------------------- > > (Updated 2010-11-03 13:27:29) > > > Review request for Amarok. > > > Summary > ------- > > Rewrite a bit TagUtility, and turn back MPC files support. > > > Diffs > ----- > > src/core-impl/collections/db/sql/SqlMeta.cpp 3943a1f > src/core-impl/meta/file/File_p.h 3dd38a4 > src/core-impl/meta/file/TagLibUtils.cpp 6eb9f60 > > Diff: http://git.reviewboard.kde.org/r/100129/diff > > > Testing > ------- > > Tested on mp3, flac and mp4 files. Unit-test also passed. > > > Thanks, > > Sergey > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
