> On 2010-11-25 10:04:30, Sergey Ivanov wrote: > > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp, line 274 > > <http://git.reviewboard.kde.org/r/100168/diff/2/?file=4282#file4282line274> > > > > What's a point to pass name to function, if you can return It from > > there, It made sense when there was another call before generatePN, but why > > do you need It now? > > Dennis Francis wrote: > I don't see what is wrong with passing an address of a variable in the > stack to the function rather than to return a pointer to a dynamically > allocated object from generatePN(). I think it is much more efficient and > clean. Passing the object as such involves bigger overhead. > > Mark Kretschmann wrote: > Is "name" a QString? Those are implicitly shared. No need to pull such > stunts. > > I agree with Sergey here. >
Yes, Thanks for the clarification ! My C background is causing much trouble here :) - Dennis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review401 ----------------------------------------------------------- On 2010-11-25 01:01:23, Dennis Francis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100168/ > ----------------------------------------------------------- > > (Updated 2010-11-25 01:01:23) > > > Review request for Amarok. > > > Summary > ------- > > The playlist name is generated as per the rules : > > if ( singleArtist && singleAlbum ) > playlistName = artist + " - " + album + ' - ' + shortDate > > else if ( !singleArtist && singleAlbum ) > playlistName = "Various" + " - " + album + ' - ' + shortDate > > else if ( singleArtist && !singleAlbum ) > playlistName = artist + " - " + "Various" + shortDate > > else > playlistName = "Various" + " - " + shortDate > > If the there are no tracks, the playlist name is set to "Empty Playlist - " + > shortDate > > > This addresses bug 185397. > https://bugs.kde.org/show_bug.cgi?id=185397 > > > Diffs > ----- > > src/playlistmanager/sql/SqlUserPlaylistProvider.h 3a5a62e > src/playlistmanager/sql/SqlUserPlaylistProvider.cpp d2ae5b9 > > Diff: http://git.reviewboard.kde.org/r/100168/diff > > > Testing > ------- > > Tested different possibilities. It is working fine for me. > > Please suggest better alternatives ( if any ) to the shortDate addition. > Without the shortDate, playlist database lookup would be necessary to > calculate a unique name. > > > Thanks, > > Dennis > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
