----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100250/#review622 -----------------------------------------------------------
First impressions from screenshot: Nice, but the two lines of ratings stars look HUGE. I'm not sure if we have these icons available in smaller size, but I think that might look better. - Mark On 2010-12-26 20:35:42, Sergey Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100250/ > ----------------------------------------------------------- > > (Updated 2010-12-26 20:35:42) > > > Review request for Amarok. > > > Summary > ------- > > Polish "a bit" filter editor dialog, now It uses tokens as TagGuesser dialog > does, and works exactly as Editor, not just like "appender" (260333 bug). > > > This addresses bug 260333. > https://bugs.kde.org/show_bug.cgi?id=260333 > > > Diffs > ----- > > src/core/meta/support/MetaConstants.cpp e2e11a9 > src/dialogs/EditFilterDialog.h 12088bc > src/dialogs/EditFilterDialog.cpp 67f1f6e > src/dialogs/EditFilterDialog.ui 4b2bf3e > src/images/icons/hi48-action-filename-and-amarok.png PRE-CREATION > src/widgets/MetaQueryWidget.h 9c1181a > src/widgets/MetaQueryWidget.cpp 8868106 > src/widgets/Token.h 134184f > src/widgets/Token.cpp b672121 > src/widgets/TokenDropTarget.cpp c454fd4 > src/widgets/TokenPool.cpp 41d462d > src/widgets/TokenWithLayout.h 744113e > src/widgets/TokenWithLayout.cpp 4f581d8 > > Diff: http://git.reviewboard.kde.org/r/100250/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/100250/s/27/ > > > Thanks, > > Sergey > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel