> On Jan. 8, 2011, 3:12 p.m., Mark Kretschmann wrote: > > Yeah, you can do that. However, I have not actually tested your patch. Does > > it change anything in the behavior of the widget?
I compiled Amarok with the first version of this patch (with «""»), and I haven't noticed any changes. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100309/#review775 ----------------------------------------------------------- On Jan. 6, 2011, 8:27 p.m., Alexander Potashev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100309/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2011, 8:27 p.m.) > > > Review request for Amarok. > > > Summary > ------- > > Reduce code duplication when filling in items of combo box. > > > Diffs > ----- > > src/widgets/MetaQueryWidget.cpp 8868106 > > Diff: http://git.reviewboard.kde.org/r/100309/diff > > > Testing > ------- > > > Thanks, > > Alexander > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel