----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ -----------------------------------------------------------
(Updated Jan. 12, 2011, 1:58 p.m.) Review request for Amarok. Changes ------- Turn back encoding detection code. But It's still switched off. Summary (updated) ------- Rewrite tag reading stuff to make It more OOP way. Add separate classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4). Exclude almost all "magic words" (frame/field names) from code. Diffs (updated) ----- shared/FileType.h dc5e57b shared/FileType.cpp 63d81c7 shared/MetaTagLib.h ff27c92 shared/MetaTagLib.cpp 90e2483 shared/TagsFromFileNameGuesser.h PRE-CREATION shared/TagsFromFileNameGuesser.cpp PRE-CREATION shared/tag_helpers/APETagHelper.h PRE-CREATION shared/tag_helpers/APETagHelper.cpp PRE-CREATION shared/tag_helpers/ASFTagHelper.h PRE-CREATION shared/tag_helpers/ASFTagHelper.cpp PRE-CREATION shared/tag_helpers/ID3v2TagHelper.h PRE-CREATION shared/tag_helpers/ID3v2TagHelper.cpp PRE-CREATION shared/tag_helpers/MP4TagHelper.h PRE-CREATION shared/tag_helpers/MP4TagHelper.cpp PRE-CREATION shared/tag_helpers/StringHelper.h PRE-CREATION shared/tag_helpers/StringHelper.cpp PRE-CREATION shared/tag_helpers/TagHelper.h PRE-CREATION shared/tag_helpers/TagHelper.cpp PRE-CREATION shared/tag_helpers/VorbisCommentTagHelper.h PRE-CREATION shared/tag_helpers/VorbisCommentTagHelper.cpp PRE-CREATION src/CMakeLists.txt 5dd4163 src/core-impl/meta/file/File_p.h 9f1df54 src/dialogs/FilenameLayoutDialog.h 0380cc1 src/dialogs/FilenameLayoutDialog.cpp 0efd23d src/dialogs/FilenameLayoutDialog.ui e75f407 src/dialogs/TagDialog.cpp 70360ff src/dialogs/TagGuesser.h c3cc89f src/dialogs/TagGuesser.cpp 869f432 src/musicbrainz/MusicBrainzFinder.cpp 78a07a6 utilities/collectionscanner/CMakeLists.txt 6be9319 Diff: http://git.reviewboard.kde.org/r/100191/diff Testing (updated) ------- Tested on small test collection of mp3, ogg, flac, mpc, m4a, wav, wma files. Also tested setting/getting of covers (mp3 - ID3v2, m4a - MP4, wma - ASF). Everything seems to work fine. Tag guesser works fine. Screenshots ----------- TagGuesser with full filepath http://git.reviewboard.kde.org/r/100191/s/25/ Thanks, Sergey
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
