----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100953/#review2229 -----------------------------------------------------------
Hi, thanks for the patch. Just letting you know I will take a look at this very soon. Cheers. - Rick W. On March 29, 2011, 4:42 p.m., Elbin Pallimalil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100953/ > ----------------------------------------------------------- > > (Updated March 29, 2011, 4:42 p.m.) > > > Review request for Amarok and Rick W. Chen. > > > Summary > ------- > > WikipediaEnginePrivate has a member "Meta::TrackPtr currentTrack" and to > check if an update is required this member is queried to get the previous > track's data. This of course would not work as this member always returns the > current data when a stream is being played. > > Can I replace this member with a struct to save Artist, Album and Track info? > Bad idea? > > > This addresses bug 266645. > https://bugs.kde.org/show_bug.cgi?id=266645 > > > Diffs > ----- > > src/context/engines/wikipedia/WikipediaEngine.cpp 1fe80ae > > Diff: http://git.reviewboard.kde.org/r/100953/diff > > > Testing > ------- > > Works with different streams. Tested by playing files as well. > > > Thanks, > > Elbin > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
