-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thx Markey for forwarding it & thx Romain for noticing it.
Will have it fixed by tomorrow evening, want to check back with my Colleague who wrote that Code first if he meant the Slots from the PodcastRequestHandler (then the Slot Names are wrong) or from the ServiceModel (where the names would be correct). Even though I'm sure he meant the first one ... but found some unused Code & a Pointer that doesn't get deleted so I will go over the code once more ... Stefan On 03/29/2011 07:44 PM, Mark Kretschmann wrote: > ---------- Forwarded message ---------- > From: <romain.per...@gmail.com> > Date: Sun, Mar 27, 2011 at 4:55 PM > Subject: Review Request: Fix incorrect slot names in gpodder service which > causes "no such slot" runtime error > To: Mark Kretschmann <kretschm...@kde.org>, Harald Sitter < > sitter.har...@gmail.com> > Cc: romain.per...@gmail.com > > > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6639/ > Review request for Harald Sitter and Mark Kretschmann. > By bambi. > Description > > When you use the gpodder service with amarok 2.4.0.90 sometimes when > you click on podcast entries you can see the following messages in a > terminal: > QObject::connect: No such slot > GpodderPodcastRequestHandler::topTagsRequestError(QNetworkReply::NetworkError) > QObject::connect: No such slot > GpodderPodcastRequestHandler::topTagsParseError() > > These slots do not exist in GpodderPodcastRequestHandler API. Change > them to requestError(QNetworkReply::NetworkError) and parserError() > solves the problem. > See the patch in attachment. > > Diffs > > - src/services/gpodder/GpodderServiceModel.cpp (af48576) > > View Diff <http://svn.reviewboard.kde.org/r/6639/diff/> > > > > > > _______________________________________________ > Amarok-devel mailing list > Amarok-devel@kde.org > https://mail.kde.org/mailman/listinfo/amarok-devel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk2SXVgACgkQlZvAMV/NgGJ4PwCgings/VHFSPJmw7oimNo2Nhm4 kI0AoMkjh3JnVo5OfGI1qcuzIC5ixxMc =3e0b -----END PGP SIGNATURE----- _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
